Add revive modules for Farooq's Revive #386

ServiusHack · 2018-09-30T17:27:46Z

When merged this pull request will:

The Instant Revive module will immediately revive the selected player
when Farooq's Revive script is active. It still takes seconds for the
player to be up because of Farooq's Revive script.
The Immersive Revive module sends a selected AI unit to the nearest
down player to revive him. This gives a more realistic feeling. Also
works on vehicles which will drive up to the player before the driver
exits and revives the player.

CreepPork · 2018-09-30T17:40:32Z

Hi, I'm impressed with the code quality and glad to see another contributor joining in (I'll do a review a bit later, I have some things that I will nitpick about and some stuff due to the upcoming 1.2.0 update) but I'm more concerned about making these into separate modules and not integrating it into the Heal module.

I see an issue with it being directly related to Farooq's Revive which isn't in the vanilla game and creating separate modules for just Farooq's Revive seems a bit excessive to me personally (as the custom module framework would be better suited to this), however, if you would integrate it into the heal module and perhaps add dialog support then you could add all your features and not create two separate modules.

CreepPork

The code is good only minor things I'd prefer differently.

...lesExpansion/addons/modules_f_achilles/FarooqsRevive/functions/fn_FarooqsReviveImmersive.sqf

...illesExpansion/addons/modules_f_achilles/FarooqsRevive/functions/fn_FarooqsReviveInstant.sqf

ServiusHack · 2018-09-30T18:16:02Z

@CreepPork thanks for the very fast reply. It's mostly separate modules because it's my first work on Achilles and dialogs were way over my head then. I'm more comfortable with the code base now so I'll look at integrating this into the heal module.

CreepPork · 2018-09-30T18:19:15Z

@CreepPork thanks for the very fast reply. It's mostly separate modules because it's my first work on Achilles and dialogs were way over my head then. I'm more comfortable with the code base now so I'll look at integrating this into the heal module.

There's nothing to worry, we all have to start somewhere. Feel free to join the Achilles Discord (the link is in the readme) and we can help you start moving it over to the Heal module.

Also, you can take a look at the dialog documentation (it still references the old dialog function as we haven't updated the docs yet but it still gives a bit of insight into the dialog).

The ACE Heal module supports reviving the selected player when Farooq's Revive script is active. It still takes seconds for the player to be up because of Farooq's Revive script.

The new Immersive Heal module gives a more realistic feeling compared to the ACE Heal module by sending an AI to revive or heal a player. It has two modes of operation: * When placed on a player the nearest AI of the same side will be sent to revive the player. * When placed on an AI the nearest player (regardless of side) will be revived. Also works on vehicles which will drive up to the player before the driver exits and revives the player.

ServiusHack · 2019-01-13T16:15:45Z

I've pushed completely reworked commits that also implement a bit more than there was initially. Looking forward to your opinions.

Stale

@AresModAchillesExpansion/addons/modules_f_achilles/ACE/functions/fn_ModuleACEHeal.sqf