This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
test: increase src/domains/splash coverage to 100%
#3392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanlikhovich
added
Complexity: Low
romanlikhovich
requested review from
faustbrian,
ItsANameToo,
luciorubeens and
samharperpittam
as code owners
ghost
added
the
This was referenced Feb 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Covered src/domains/splash to 100%
Added more test cases for missed lines and branches. Changed test.yml and generate-test-workflow.js for src/domains/splash to 100
Checklist