This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
feat(ledger): add schnorr support #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add support for Schnorr signatures w/Ledger on tx-versions >= 2. - + `signTransactionWithSchnorr` - + `signMessageWithSchnorr` - add a check for tx-version to `services/transaction.js`. - add unit tests for additions/changes.
sleepdefic1t
requested review from
alexbarnsley,
faustbrian,
ItsANameToo and
luciorubeens
as code owners
ghost
added
Complexity: Medium
ghost
mentioned this pull request
samharperpittam
approved these changes
Jun 10, 2020
faustbrian
approved these changes
Jun 10, 2020
faustbrian
changed the title
ghost
deleted the
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ledger-Transportpackage,1.0.5->1.1.1.signMessageWithSchnorrsignTransactionWithSchnorrservices/transaction.js.Checklist
Additional Comments
WIP until Ledger-Transport 1.1.0 is released and can be updated here.WIP until testing is done and functionality is confirmed for NanoS & NanoX.