Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

chore(config): add plugin comment #1907

Merged
merged 3 commits into from
Apr 29, 2020

Conversation

sleepdefic1t
Copy link
Contributor

@sleepdefic1t sleepdefic1t commented Apr 20, 2020

Summary

Minor change adding a comment about changing the plugin config.

It's already fairly obvious the plugin section shouldn't be changed when you look at what it does,
but this comment could still be pretty useful for others.

// This section handles fetching Desktop-Wallet Plugins from the NPM registry.
// It should remain "ARK" unless intentionally implementing a custom package.

Checklist

  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels Apr 20, 2020
@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #1907 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1907   +/-   ##
========================================
  Coverage    59.04%   59.04%           
========================================
  Files          373      373           
  Lines         9294     9294           
  Branches      1921     1921           
========================================
  Hits          5488     5488           
  Misses        3580     3580           
  Partials       226      226           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f6200a...d25093c. Read the comment docs.

config/index.js Outdated Show resolved Hide resolved
@alexbarnsley alexbarnsley merged commit 7d54075 into develop Apr 29, 2020
@ghost ghost deleted the chore(config)/add-plugin-comment branch April 29, 2020 14:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants