Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

chore: remove the cursor and opacity for avatar and background selection #1893

Merged
merged 2 commits into from
Apr 9, 2020

Conversation

brenopolanski
Copy link
Contributor

@brenopolanski brenopolanski commented Apr 7, 2020

Summary

When creating and editing a new profile, avatar and background images should not have click action. So there is no need for a cursor pointer and opacity styles.

Current Behavior

Peek 2020-04-07 15-26

Peek 2020-04-07 15-27

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels Apr 7, 2020
@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #1893 into develop will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1893   +/-   ##
========================================
  Coverage    58.88%   58.88%           
========================================
  Files          371      371           
  Lines         9305     9305           
  Branches      1920     1920           
========================================
  Hits          5479     5479           
  Misses        3600     3600           
  Partials       226      226           
Impacted Files Coverage Δ
src/renderer/pages/Profile/ProfileEdition.vue 6.28% <ø> (ø)
src/renderer/pages/Profile/ProfileNew.vue 7.60% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40d0481...1f2fccc. Read the comment docs.

@faustbrian faustbrian merged commit 5069a12 into develop Apr 9, 2020
@ghost ghost deleted the chore/remove-click-avatar-image branch April 9, 2020 03:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants