Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: grant icon & fetching plugin config #1860

Merged
merged 17 commits into from
Mar 24, 2020
Merged

Conversation

brenopolanski
Copy link
Contributor

@brenopolanski brenopolanski commented Mar 24, 2020

Summary

Add the grant icon and update the check mark icon.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Feature The issue is a request for new functionality. labels Mar 24, 2020
@alexbarnsley
Copy link
Member

@brenopolanski tests are failing 👀

Copy link
Member

@alexbarnsley alexbarnsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just need some tests @brenopolanski

config/index.js Outdated Show resolved Hide resolved
config/index.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #1860 into staging will increase coverage by 0.01%.
The diff coverage is 76.47%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging    #1860      +/-   ##
===========================================
+ Coverage    60.84%   60.86%   +0.01%     
===========================================
  Files          370      371       +1     
  Lines         9293     9300       +7     
  Branches      1918     1919       +1     
===========================================
+ Hits          5654     5660       +6     
- Misses        3468     3469       +1     
  Partials       171      171              
Impacted Files Coverage Δ
src/renderer/App.vue 23.61% <0.00%> (ø)
...omponents/PluginManager/PluginManagerCheckmark.vue 100.00% <ø> (ø)
src/renderer/services/plugin-manager.js 49.14% <57.14%> (-0.58%) ⬇️
...r/components/PluginManager/PluginManagerGrants.vue 100.00% <100.00%> (ø)
...rer/components/PluginManager/PluginManagerGrid.vue 100.00% <100.00%> (ø)
...Manager/PluginManagerModals/PluginDetailsModal.vue 86.48% <100.00%> (ø)
...er/components/PluginManager/PluginManagerTable.vue 100.00% <100.00%> (ø)
src/renderer/store/modules/plugin.js 99.13% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 405c38f...e95f905. Read the comment docs.

@alexbarnsley alexbarnsley dismissed samharperpittam’s stale review March 24, 2020 21:11

The base branch was changed.

@alexbarnsley alexbarnsley changed the base branch from develop to staging March 24, 2020 21:11
@alexbarnsley alexbarnsley changed the base branch from staging to develop March 24, 2020 22:08
@alexbarnsley alexbarnsley changed the base branch from develop to staging March 24, 2020 22:08
@alexbarnsley alexbarnsley changed the title feat: add ark grant icon refactor: grant icon & fetching plugin config Mar 24, 2020
@alexbarnsley alexbarnsley merged commit 4315524 into staging Mar 24, 2020
@ghost ghost deleted the feat/ark-grant-icon branch March 24, 2020 22:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Medium Less than 256 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants