This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 190
refactor: grant icon & fetching plugin config #1860
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenopolanski
requested review from
alexbarnsley,
faustbrian,
ItsANameToo and
luciorubeens
as code owners
March 24, 2020 04:59
ghost
added
Complexity: Medium
Less than 256 lines changed.
Type: Feature
The issue is a request for new functionality.
labels
Mar 24, 2020
@brenopolanski tests are failing 👀 |
alexbarnsley
previously requested changes
Mar 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, just need some tests @brenopolanski
Codecov Report
@@ Coverage Diff @@
## staging #1860 +/- ##
===========================================
+ Coverage 60.84% 60.86% +0.01%
===========================================
Files 370 371 +1
Lines 9293 9300 +7
Branches 1918 1919 +1
===========================================
+ Hits 5654 5660 +6
- Misses 3468 3469 +1
Partials 171 171
Continue to review full report at Codecov.
|
brenopolanski
commented
Mar 24, 2020
samharperpittam
previously approved these changes
Mar 24, 2020
alexbarnsley
dismissed
samharperpittam’s stale review
March 24, 2020 21:11
The base branch was changed.
alexbarnsley
approved these changes
Mar 24, 2020
alexbarnsley
changed the title
feat: add ark grant icon
refactor: grant icon & fetching plugin config
Mar 24, 2020
ghost
deleted the
feat/ark-grant-icon
branch
March 24, 2020 22:49
ghost
mentioned this pull request
Mar 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Complexity: Medium
Less than 256 lines changed.
Type: Feature
The issue is a request for new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the grant icon and update the check mark icon.
Checklist