Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: spacing & word wrap of alerts #1841

Merged
merged 5 commits into from
Mar 17, 2020
Merged

fix: spacing & word wrap of alerts #1841

merged 5 commits into from
Mar 17, 2020

Conversation

brenopolanski
Copy link
Contributor

Summary

Before:

Screenshot from 2020-03-16 15-51-48

After:

Screenshot from 2020-03-16 16-20-37

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Mar 16, 2020
@codecov
Copy link

codecov bot commented Mar 16, 2020 •
edited
Loading

Codecov Report

Merging #1841 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1841   +/-   ##
========================================
  Coverage    60.01%   60.01%           
========================================
  Files          369      369           
  Lines         9232     9232           
  Branches      1896     1896           
========================================
  Hits          5541     5541           
  Misses        3500     3500           
  Partials       191      191
Impacted Files Coverage Δ
.../renderer/components/AlertMessage/AlertMessage.vue 87.5% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5353b7b...b355b99. Read the comment docs.

@alexbarnsley
Copy link
Member

Looks good @brenopolanski! Could you try adding some padding between the message and the close button, please

@brenopolanski
Copy link
Contributor Author

@alexbarnsley fixed:

Screenshot from 2020-03-17 15-20-39

@alexbarnsley alexbarnsley changed the title fix: add .break-words to add line breaks middle of the message if needed fix: spacing & word wrap of alerts Mar 17, 2020
@alexbarnsley alexbarnsley merged commit b98bb1c into develop Mar 17, 2020
@ghost ghost deleted the fix/alert-message-break-words branch March 17, 2020 19:25
@ghost ghost mentioned this pull request Mar 22, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexbarnsley alexbarnsley alexbarnsley approved these changes

@faustbrian faustbrian Awaiting requested review from faustbrian

@ItsANameToo ItsANameToo Awaiting requested review from ItsANameToo ItsANameToo is a code owner

@luciorubeens luciorubeens Awaiting requested review from luciorubeens

Assignees
No one assigned
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brenopolanski @alexbarnsley