This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
fix: close modal using the esc key after pressing other keys #1828
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1827.
The
once
property inaddEventListener
has been removed because if true, the listener would be automatically removed when invoked.The
keyCode
is deprecated: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCodeThe problem with using
keyCode
is that non-English keyboards can produce different outputs and even keyboards with different layouts can produce inconsistent results.Checklist