Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: expose peer discovery to plugins #1808

Merged
merged 2 commits into from
Mar 10, 2020
Merged

feat: expose peer discovery to plugins #1808

merged 2 commits into from
Mar 10, 2020

Conversation

dated
Copy link
Contributor

@dated dated commented Mar 9, 2020

Summary

This PR exposes an instance of the peer discovery to the plugin system. The instance is created by leveraging the getPeerDiscovery dispatch method from the peer store module in order to not duplicate the instantiation logic.

const peerDiscovery = (await app.$store.dispatch('peer/getPeerDiscovery'))
      .withLatency(300)
      .sortBy('latency')

Permission: PEERS_ALL

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost
Copy link

ghost commented Mar 9, 2020

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Feature The issue is a request for new functionality. labels Mar 9, 2020
@faustbrian faustbrian added the Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. label Mar 10, 2020
@faustbrian faustbrian merged commit 8336963 into ArkEcosystem:develop Mar 10, 2020
@ghost
Copy link

ghost commented Mar 10, 2020

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

@dated dated deleted the feat/expose-peer-discovery branch March 10, 2020 04:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bounty: Tier 4 Awarded for small features, refactorings, improvements. This is valued at 20 USD. Complexity: Low Less than 64 lines changed. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants