Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: plugin image slider #1783

Merged
merged 7 commits into from
Mar 7, 2020
Merged

feat: plugin image slider #1783

merged 7 commits into from
Mar 7, 2020

Conversation

alexbarnsley
Copy link
Member

Summary

  • Change to use plugin image thumbnails
  • Add modal to view plugin thumbnails

Todo in the future:

  • Slider component to reduce code smell between the 2 components

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: High More than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Mar 6, 2020
@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #1783 into develop will decrease coverage by 0.17%.
The diff coverage is 13.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1783      +/-   ##
===========================================
- Coverage    59.89%   59.71%   -0.18%     
===========================================
  Files          366      367       +1     
  Lines         9146     9178      +32     
  Branches      1848     1854       +6     
===========================================
+ Hits          5478     5481       +3     
- Misses        3486     3515      +29     
  Partials       182      182              
Impacted Files Coverage Δ
...inManager/PluginManagerModals/PluginImageModal.vue 7.14% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d011b1d...480b75c. Read the comment docs.

@faustbrian faustbrian changed the title refactor: plugin image slider feat: plugin image slider Mar 6, 2020
@alexbarnsley alexbarnsley changed the base branch from develop to staging March 6, 2020 21:58
@faustbrian faustbrian merged commit ba1f575 into staging Mar 7, 2020
@ghost ghost deleted the refactor/plugin-image-slider branch March 7, 2020 03:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: High More than 256 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants