feat: fetch known wallets from repository #1766
Conversation
dated
requested review from
alexbarnsley,
faustbrian,
ItsANameToo and
luciorubeens
as code owners
|
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
ghost
added
Complexity: Low
dated
changed the title
ghost
mentioned this pull request
|
@dated How are you planning to do this? |
|
The known wallets will be fetched from https://github.com/ArkEcosystem/common |
dav1app
added
the
Status: In Progress
dated
changed the title
brenopolanski
removed
the
Status: In Progress
| @@ -651,6 +667,14 @@ export default { | |||
| return !this.showFull || /^https?:\/\//.test(value) | |||
| } | |||
| }, | |||
| knownWalletsUrl: { | |||
| required () { | |||
| return true | |||
There was a problem hiding this comment.
I don't think this field should be required, otherwise the wallet won't be able to add bridgechains without it 🤔
There was a problem hiding this comment.
It always validates to true, it's basically a "Hack" so i could use the required url field error method.
|
A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
ghost
added
the
Status: Member Approved
|
Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days. |
alexbarnsley
added
the
Bounty: Tier 4
|
Your pull request has been merged and marked as tier 4. It will earn you $20 USD. |
ghost
mentioned this pull request
Summary
The known wallets are now available in the https://github.com/ArkEcosystem/common repository.
NB: When updating a profile vuex shows a warning, which is unrelated to these changes.
Checklist