Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: use showSaveDialog with promise instead of callback #1711

Merged
merged 2 commits into from
Feb 26, 2020

Conversation

faustbrian
Copy link
Contributor

Changed but not mentioned in v7 or v8 changelog

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Feb 26, 2020
@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #1711 into develop will decrease coverage by 0.05%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1711      +/-   ##
===========================================
- Coverage    69.51%   69.46%   -0.06%     
===========================================
  Files          139      139              
  Lines         3809     3815       +6     
  Branches       795      797       +2     
===========================================
+ Hits          2648     2650       +2     
- Misses         996      999       +3     
- Partials       165      166       +1
Impacted Files Coverage Δ
src/renderer/store/modules/plugin.js 100% <100%> (ø) ⬆️
src/renderer/models/profile.js 100% <100%> (ø) ⬆️
src/renderer/store/modules/session.js 36.89% <33.33%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f494ca...ac49102. Read the comment docs.

@faustbrian faustbrian merged commit 3545736 into develop Feb 26, 2020
@ghost ghost deleted the faustbrian-patch-1 branch February 26, 2020 13:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant