Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: transaction list multi-payment amount #1668

Merged
merged 14 commits into from
Feb 18, 2020
Merged

fix: transaction list multi-payment amount #1668

merged 14 commits into from
Feb 18, 2020

Conversation

alexbarnsley
Copy link
Member

@alexbarnsley alexbarnsley commented Feb 12, 2020 •
edited
Loading

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Feb 12, 2020
@codecov
Copy link

codecov bot commented Feb 12, 2020 •
edited
Loading

Codecov Report

Merging #1668 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1668      +/-   ##
===========================================
+ Coverage    62.95%   62.97%   +0.01%     
===========================================
  Files          135      135              
  Lines         3663     3681      +18     
  Branches       767      776       +9     
===========================================
+ Hits          2306     2318      +12     
- Misses        1134     1138       +4     
- Partials       223      225       +2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e3d254...14b9e83. Read the comment docs.

dated
dated reviewed Feb 14, 2020
View reviewed changes
src/renderer/i18n/locales/en-US.js Outdated
@@ -991,6 +991,7 @@ export default {
HTLC_CLAIM: 'Timelock Claim could not be created',
HTLC_REFUND: 'Timelock Refund could not be created',
MULTI_PAYMENT: 'Multi payment could not be created',
MULTI_PAYMENT_TO_SELF: 'Excluding {amount} the sender sent to themselves',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI we eventually settled on themself instead of themselves on the explorer (https://dictionary.cambridge.org/dictionary/english/themself).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going with Excluding {amount} sent to itself since I'm not happy with either to be honest.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that neither themself nor themselves sounds natural in this context, ditto with the explorer.

@ghost ghost mentioned this pull request Feb 16, 2020
Closed
@alexbarnsley alexbarnsley merged commit 7250665 into develop Feb 18, 2020
@ghost ghost deleted the fix/multipayment-amount branch February 18, 2020 16:25
@ghost ghost mentioned this pull request Feb 23, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alessiodf alessiodf alessiodf left review comments

@dated dated dated left review comments

@faustbrian faustbrian faustbrian approved these changes

@dav1app dav1app dav1app approved these changes

@brenopolanski brenopolanski brenopolanski approved these changes

@ItsANameToo ItsANameToo Awaiting requested review from ItsANameToo ItsANameToo is a code owner

@luciorubeens luciorubeens Awaiting requested review from luciorubeens

Assignees
No one assigned
Labels
Complexity: Medium Less than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexbarnsley @brenopolanski @dav1app @dated @faustbrian @alessiodf