This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
fix: business, bridgechain & delegate tweaks #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbarnsley
requested review from
faustbrian,
ItsANameToo and
luciorubeens
as code owners
ghost
added
Complexity: Low
Codecov Report
@@ Coverage Diff @@
## develop #1667 +/- ##
===========================================
+ Coverage 62.97% 63.08% +0.11%
===========================================
Files 135 135
Lines 3681 3684 +3
Branches 776 777 +1
===========================================
+ Hits 2318 2324 +6
+ Misses 1138 1135 -3
Partials 225 225
Continue to review full report at Codecov.
|
alexbarnsley
changed the title
ghost
mentioned this pull request
dav1app
reviewed
Feb 17, 2020
src/renderer/services/wallet.js
Outdated
| @@ -127,7 +127,6 @@ export default class WalletService { | |||
| * @returns {Boolean} | |||
| */ | |||
| static canResignDelegate (wallet) { | |||
| console.log('canResignDelegate', wallet) | |||
There was a problem hiding this comment.
Why we don't have a debug mode?
There was a problem hiding this comment.
That was debug code I added during development. Leaving stuff like that in would make the code messy. We use logger.$error for some areas where it might be useful (e.g. a try/catch) but that's all.
There was a problem hiding this comment.
It has already been removed!
brenopolanski
approved these changes
Feb 17, 2020
dav1app
approved these changes
Feb 18, 2020
faustbrian
approved these changes
Feb 18, 2020
ghost
deleted the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist