Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: erase bug on input fee #1666

Merged
merged 5 commits into from
Feb 24, 2020
Merged

fix: erase bug on input fee #1666

merged 5 commits into from
Feb 24, 2020

Conversation

dav1app
Copy link
Contributor

@dav1app dav1app commented Feb 11, 2020

This fix #1421 .

Summary

It is important to notice that this change adds a @change event to the input. This event is consumed by InputFee and only after that the @input is emitted.

This means InputCurrency@input -> InputFee@change -> InputFee@input on this particular component. This can be considered counter-intuitive. The desired way is to implement @change on every instance that requires a state change. @input should only edit the user input (handle masks, prevent types).

Checklist

  • Documentation
  • Tests.
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. Status: In Progress The issue or pull request is being worked on. labels Feb 11, 2020
@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #1666 into develop will decrease coverage by 0.04%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1666      +/-   ##
===========================================
- Coverage    63.91%   63.86%   -0.05%     
===========================================
  Files          138      139       +1     
  Lines         3813     3814       +1     
  Branches       797      797              
===========================================
- Hits          2437     2436       -1     
- Misses        1150     1152       +2     
  Partials       226      226
Impacted Files Coverage Δ
src/renderer/splashscreen.js 0% <0%> (ø)
...ts/Wallet/WalletTransactions/WalletTransactions.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 409636b...a4ecac3. Read the comment docs.

@alexbarnsley alexbarnsley added the Status: Needs Testcase The issue or pull request relates to a feature that needs test coverage. label Feb 14, 2020
@ghost
Copy link

ghost commented Feb 14, 2020

Your pull request doesn't have a test case, which is a requirement for it to be merged. Please provide it and one of the developers will review it before merging.

@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Feb 20, 2020
@dav1app dav1app removed the Status: Needs Testcase The issue or pull request relates to a feature that needs test coverage. label Feb 20, 2020
@alexbarnsley alexbarnsley merged commit 5eb5acb into develop Feb 24, 2020
@ghost ghost deleted the fix/fee-input branch February 24, 2020 23:55
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Feb 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Writing small fees with comma and leading 0 results in deleting first 0 after a comma
3 participants