This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: Low
Less than 64 lines changed.
Type: Bugfix
The pull request fixes an incorrect functionality or behaviour.
Status: In Progress
The issue or pull request is being worked on.
labels
Feb 11, 2020
Codecov Report
@@ Coverage Diff @@
## develop #1666 +/- ##
===========================================
- Coverage 63.91% 63.86% -0.05%
===========================================
Files 138 139 +1
Lines 3813 3814 +1
Branches 797 797
===========================================
- Hits 2437 2436 -1
- Misses 1150 1152 +2
Partials 226 226
Continue to review full report at Codecov.
|
alexbarnsley
added
the
Status: Needs Testcase
The issue or pull request relates to a feature that needs test coverage.
label
Feb 14, 2020
Your pull request doesn't have a test case, which is a requirement for it to be merged. Please provide it and one of the developers will review it before merging. |
ghost
mentioned this pull request
Feb 16, 2020
faustbrian
requested review from
alexbarnsley,
faustbrian,
ItsANameToo and
luciorubeens
as code owners
February 20, 2020 04:12
ghost
added
Status: Needs Review
The issue or pull request needs a review by a developer of the team.
and removed
Status: In Progress
The issue or pull request is being worked on.
labels
Feb 20, 2020
dav1app
removed
the
Status: Needs Testcase
The issue or pull request relates to a feature that needs test coverage.
label
Feb 20, 2020
alexbarnsley
approved these changes
Feb 24, 2020
ghost
deleted the
fix/fee-input
branch
February 24, 2020 23:55
ghost
removed
the
Status: Needs Review
The issue or pull request needs a review by a developer of the team.
label
Feb 24, 2020
ghost
mentioned this pull request
Mar 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Complexity: Low
Less than 64 lines changed.
Type: Bugfix
The pull request fixes an incorrect functionality or behaviour.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix #1421 .
Summary
It is important to notice that this change adds a
@change
event to the input. This event is consumed byInputFee
and only after that the@input
is emitted.This means
InputCurrency@input
->InputFee@change
->InputFee@input
on this particular component. This can be considered counter-intuitive. The desired way is to implement@change
on every instance that requires a state change.@input
should only edit the user input (handle masks, prevent types).Checklist