This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 190
fix: off by one error in recipients validation and count in list title #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dated
requested review from
alexbarnsley,
faustbrian,
ItsANameToo and
luciorubeens
as code owners
February 11, 2020 09:28
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
ghost
added
Complexity: Low
Less than 64 lines changed.
Type: Bugfix
The pull request fixes an incorrect functionality or behaviour.
labels
Feb 11, 2020
ghost
mentioned this pull request
Feb 16, 2020
alexbarnsley
approved these changes
Feb 18, 2020
ghost
added
the
Status: Member Approved
The pull request has been approved by a member.
label
Feb 18, 2020
A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution! |
Your pull request has been merged but was not assigned a bounty tier. A maintainer will assign a bounty tier to this pull request in the next few days. |
alexbarnsley
added
the
Bounty: Tier 4
Awarded for small features, refactorings, improvements. This is valued at 20 USD.
label
Feb 18, 2020
Your pull request has been merged and marked as tier 4. It will earn you $20 USD. |
ghost
mentioned this pull request
Feb 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Bounty: Tier 4
Awarded for small features, refactorings, improvements. This is valued at 20 USD.
Complexity: Low
Less than 64 lines changed.
Status: Member Approved
The pull request has been approved by a member.
Type: Bugfix
The pull request fixes an incorrect functionality or behaviour.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
InputEditableList
component, see screenshots belowChecklist