This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
fix: remove mouseup capabilities to trigger modal close. #1653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug that allow mouseup to behave as a click event on modals backdrop, since it is fired by mousedown inside a child component and mouseup inside a parent component, firing the click and closing the modal.
Summary
click
tomousedown.left
.options
doesn't work onbeta-29
.Checklist