Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: avatar error on new profile during onboarding #1633

Merged
merged 16 commits into from
Feb 27, 2020
Merged

fix: avatar error on new profile during onboarding #1633

merged 16 commits into from
Feb 27, 2020

Conversation

brenopolanski
Copy link
Contributor

@brenopolanski brenopolanski commented Jan 29, 2020 •
edited
Loading

Summary

Fixes #1613.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Jan 29, 2020
@alexbarnsley alexbarnsley changed the title fix: avatar returns a TypeError when create a new profile in onboardi… fix: avatar error on new profile during onboarding Jan 31, 2020
@ghost ghost mentioned this pull request Feb 2, 2020
Closed
alexbarnsley
alexbarnsley suggested changes Feb 11, 2020
View reviewed changes
src/renderer/App.vue Show resolved Hide resolved
@alexbarnsley alexbarnsley added Status: Needs Changes The pull request needs additional changes before it can be merged. Status: Needs Testcase The issue or pull request relates to a feature that needs test coverage. labels Feb 11, 2020
@ghost
Copy link

ghost commented Feb 11, 2020

Your pull request doesn't have a test case, which is a requirement for it to be merged. Please provide it and one of the developers will review it before merging.

alexbarnsley
alexbarnsley suggested changes Feb 26, 2020
View reviewed changes
Copy link
Member

@alexbarnsley alexbarnsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments. Also, can you had tests for the opposite case (e.g. "does not have a profile")

__tests__/unit/App.spec.js Outdated Show resolved Hide resolved
src/renderer/App.vue Show resolved Hide resolved
@faustbrian faustbrian merged commit 085b418 into ArkEcosystem:develop Feb 27, 2020
@ghost ghost mentioned this pull request Mar 1, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@faustbrian faustbrian Awaiting requested review from faustbrian

@ItsANameToo ItsANameToo Awaiting requested review from ItsANameToo ItsANameToo is a code owner

@luciorubeens luciorubeens Awaiting requested review from luciorubeens

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley

Assignees
No one assigned
Labels
Complexity: Low Less than 64 lines changed. Status: Needs Changes The pull request needs additional changes before it can be merged. Status: Needs Testcase The issue or pull request relates to a feature that needs test coverage. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not selecting an avatar returns a TypeError
3 participants
@brenopolanski @alexbarnsley @faustbrian