Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

refactor: menu consistencies #1555

Merged
merged 3 commits into from
Nov 26, 2019
Merged

refactor: menu consistencies #1555

merged 3 commits into from
Nov 26, 2019

Conversation

alexbarnsley
Copy link
Member

It is difficult to position the arrow relating to the menus, so we've decided to remove them. They didn't serve many purposes. The plugins menu list has also been "fixed" to be in dark mode, to match the other 2 menus from the sidebar, and the position has been fixed when there is only 1 plugin menu item.

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Refactor The pull request improves or enhances an existing implementation. labels Nov 22, 2019
@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #1555 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1555   +/-   ##
========================================
  Coverage    45.68%   45.68%           
========================================
  Files          274      274           
  Lines         6849     6849           
  Branches      1342     1342           
========================================
  Hits          3129     3129           
  Misses        3558     3558           
  Partials       162      162
Impacted Files Coverage Δ
...nderer/components/Menu/MenuOptions/MenuOptions.vue 100% <ø> (ø) ⬆️
.../components/App/AppSidemenu/AppSidemenuPlugins.vue 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6889f50...7b352a5. Read the comment docs.

@alexbarnsley alexbarnsley merged commit d232b8e into develop Nov 26, 2019
@ghost ghost deleted the fix/plugin-menu branch November 26, 2019 14:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Refactor The pull request improves or enhances an existing implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants