Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: add network fails #1551

Merged
merged 4 commits into from
Dec 5, 2019
Merged

fix: add network fails #1551

merged 4 commits into from
Dec 5, 2019

Conversation

alexbarnsley
Copy link
Member

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Nov 21, 2019
@codecov
Copy link

codecov bot commented Nov 21, 2019

Codecov Report

Merging #1551 into develop will increase coverage by 0.17%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1551      +/-   ##
===========================================
+ Coverage     45.7%   45.87%   +0.17%     
===========================================
  Files          274      274              
  Lines         6853     6855       +2     
  Branches      1343     1343              
===========================================
+ Hits          3132     3145      +13     
+ Misses        3559     3548      -11     
  Partials       162      162
Impacted Files Coverage Δ
src/renderer/components/Network/NetworkModal.vue 50.63% <100%> (+7.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97adaed...8be6881. Read the comment docs.

@alexbarnsley alexbarnsley merged commit 21b3a96 into develop Dec 5, 2019
@ghost ghost deleted the fix/adding-network branch December 5, 2019 10:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Medium Less than 256 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants