Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: class-based languages for localization #1495

Merged
merged 14 commits into from
Feb 26, 2020
Merged

feat: class-based languages for localization #1495

merged 14 commits into from
Feb 26, 2020

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Oct 1, 2019

Moves all localization logic into classes and only ships en-US by default. Paves the way for localization plugins.

@ghost ghost added Complexity: Undetermined Needs specialized, in-depth review. Type: Feature The issue is a request for new functionality. Status: In Progress The issue or pull request is being worked on. labels Oct 1, 2019
@alexbarnsley
Copy link
Member

image

I love it, such elegance. Such beauty. Exquisite if I may say so myself

@alexbarnsley
Copy link
Member

loljk, i'll take a look

@alexbarnsley alexbarnsley changed the title feat: localization plugins [WIP] feat: localization plugins Nov 21, 2019
@faustbrian faustbrian changed the title [WIP] feat: localization plugins feat: localization plugins Feb 26, 2020
@faustbrian faustbrian marked this pull request as ready for review February 26, 2020 13:25
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Feb 26, 2020
@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #1495 into develop will increase coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1495      +/-   ##
===========================================
+ Coverage    69.19%   69.45%   +0.25%     
===========================================
  Files          140      140              
  Lines         3844     3824      -20     
  Branches       800      797       -3     
===========================================
- Hits          2660     2656       -4     
+ Misses        1015     1002      -13     
+ Partials       169      166       -3
Impacted Files Coverage Δ
src/renderer/store/modules/announcements.js 72.72% <0%> (-6.23%) ⬇️
src/renderer/i18n/index.js 100% <0%> (ø) ⬆️
src/renderer/mixins/electron.js 0% <0%> (ø) ⬆️
src/renderer/store/modules/delegate.js 61.53% <0%> (+3.53%) ⬆️
src/renderer/store/modules/transaction.js 53.33% <0%> (+7.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0038d96...5fb7f0f. Read the comment docs.

@faustbrian faustbrian changed the title feat: localization plugins feat: class-based languages for localization Feb 26, 2020
package.json Outdated Show resolved Hide resolved
@faustbrian faustbrian merged commit 6399cb6 into develop Feb 26, 2020
@ghost ghost deleted the locale branch February 26, 2020 14:33
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Feb 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Undetermined Needs specialized, in-depth review. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants