This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 190
feat: class-based languages for localization #1495
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Complexity: Undetermined
Needs specialized, in-depth review.
Type: Feature
The issue is a request for new functionality.
Status: In Progress
The issue or pull request is being worked on.
labels
Oct 1, 2019
ghost
mentioned this pull request
Oct 6, 2019
loljk, i'll take a look |
alexbarnsley
changed the title
feat: localization plugins
[WIP] feat: localization plugins
Nov 21, 2019
faustbrian
changed the title
[WIP] feat: localization plugins
feat: localization plugins
Feb 26, 2020
faustbrian
requested review from
alexbarnsley,
ItsANameToo and
luciorubeens
as code owners
February 26, 2020 13:25
ghost
added
Status: Needs Review
The issue or pull request needs a review by a developer of the team.
and removed
Status: In Progress
The issue or pull request is being worked on.
labels
Feb 26, 2020
Codecov Report
@@ Coverage Diff @@
## develop #1495 +/- ##
===========================================
+ Coverage 69.19% 69.45% +0.25%
===========================================
Files 140 140
Lines 3844 3824 -20
Branches 800 797 -3
===========================================
- Hits 2660 2656 -4
+ Misses 1015 1002 -13
+ Partials 169 166 -3
Continue to review full report at Codecov.
|
faustbrian
changed the title
feat: localization plugins
feat: class-based languages for localization
Feb 26, 2020
ghost
deleted the
locale
branch
February 26, 2020 14:33
ghost
removed
the
Status: Needs Review
The issue or pull request needs a review by a developer of the team.
label
Feb 26, 2020
ghost
mentioned this pull request
Mar 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Complexity: Undetermined
Needs specialized, in-depth review.
Type: Feature
The issue is a request for new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all localization logic into classes and only ships
en-US
by default. Paves the way for localization plugins.