Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

ci: setup github action workflow for testing #1462

Merged
merged 15 commits into from
Sep 23, 2019
Merged

ci: setup github action workflow for testing #1462

merged 15 commits into from
Sep 23, 2019

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Sep 21, 2019

Setup lint, depcheck and unit testing as workflows for GitHub Actions.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@ghost ghost added Complexity: Medium Less than 256 lines changed. Status: In Progress The issue or pull request is being worked on. labels Sep 21, 2019
@faustbrian faustbrian marked this pull request as ready for review September 21, 2019 03:54
@ghost ghost added Status: Needs Review The issue or pull request needs a review by a developer of the team. and removed Status: In Progress The issue or pull request is being worked on. labels Sep 21, 2019
@codecov
Copy link

codecov bot commented Sep 21, 2019

Codecov Report

Merging #1462 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1462   +/-   ##
========================================
  Coverage    41.41%   41.41%           
========================================
  Files          237      237           
  Lines         6616     6616           
  Branches      1299     1299           
========================================
  Hits          2740     2740           
  Misses        3646     3646           
  Partials       230      230

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c60b941...56463e3. Read the comment docs.

@alexbarnsley
Copy link
Member

@faustbrian there are failing things

@faustbrian
Copy link
Contributor Author

Yeah, it's just the depcheck task which is unrelated to this PR. I'll send another PR to fix that issue.

@faustbrian
Copy link
Contributor Author

@alexbarnsley

@faustbrian faustbrian merged commit 68471e4 into develop Sep 23, 2019
@ghost ghost deleted the gh-actions branch September 23, 2019 09:06
@ghost ghost removed the Status: Needs Review The issue or pull request needs a review by a developer of the team. label Sep 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Medium Less than 256 lines changed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants