Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

chore(deps): upgrade vm2 to 3.8.4 #1456

Merged
merged 1 commit into from
Sep 15, 2019
Merged

chore(deps): upgrade vm2 to 3.8.4 #1456

merged 1 commit into from
Sep 15, 2019

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Sep 13, 2019

3.8.4 includes various fixes for ways to break out of the VM.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks. labels Sep 13, 2019
@codecov-io
Copy link

Codecov Report

Merging #1456 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1456   +/-   ##
========================================
  Coverage    40.75%   40.75%           
========================================
  Files          237      237           
  Lines         6547     6547           
  Branches      1292     1299    +7     
========================================
  Hits          2668     2668           
+ Misses        3635     3634    -1     
- Partials       244      245    +1
Impacted Files Coverage Δ
src/renderer/components/Network/NetworkModal.vue 41.66% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1c6d40...95f5e7f. Read the comment docs.

@faustbrian faustbrian merged commit c1997e1 into develop Sep 15, 2019
@ghost ghost deleted the deps/vm2 branch September 15, 2019 11:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Low Less than 64 lines changed. Type: Task The issue is a request to setup third-party integrations or any general non-code related tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants