refactor: hide delegate tab if wallet is not on profile

[dated]

1. explicitly set cursor-pointer on anchors in the wallet address component (the pointer is missing on the transaction show modal for instance)
2. hide the delegate tab if the current wallet is not owned

What kind of change does this PR introduce?

• Bugfix
• Feature
• Refactor
• Performance
• Tests
• Build
• Documentation
• Code style update
• Continuous Integration
• Other, please describe:

Does this PR introduce a breaking change?

• Yes
• No

Does this PR release a new version?

• Yes
• No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

• It's submitted to the develop branch, not the master branch
• All tests are passing
• New/updated tests are included

If adding a new feature, the PR's description includes:

• A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

[ghost]

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

[luciorubeens]

It's useful for viewing the vote, this info should appear at least elsewhere before we hide the tab.

[alexbarnsley]

Perhaps make use of the vote status bar, hide the vote/unvote & search buttons

[alexbarnsley]

Actually, that only shows on the delegate tab so I'm not sure where you would show it 🤔

[dated]

Actually the status bar doesn't show for unowned wallets, so that information isn't necessarily obtainable from the first page of the delegate table either.

One could repurpose the dot that shows up in the wallet header when a wallet is not voting to show that a wallet is in fact voting, while displaying the delegate name on hover. But that might also require some modification to the red dot in the wallet table, which currently holds a conflicting type of information (as it shows up only if a voted delegate is out of the top X).

[ghost]

Your pull request needs some changes. Please wait for a comment from one of our developers for more information.

[dated]

Opinions anyone? :D

[alexbarnsley]

🤔 not sure why I added the label but didn't respond. maybe as you say, use the dot. Perhaps we show an orange dot for no vote, a green dot for a vote and show it for all wallets

[dated]

👌 i'll try something in the next couple of days

[alexbarnsley]

@dated did you get around to taking a look at this?

[dated]

Nah, been busy with the plugin manager. I'll have a look this afternoon.

[dated]

Instead of using colors (orange / green) I would propose to use an empty and filled circle instead.

[alexbarnsley]

No worries! Yeh that sounds good 👌

[ghost]

A member has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

[ghost]

Your pull request has been merged and marked as tier 3. It will earn you $50 USD.