Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat(aip-11): v2 transactions with nonces #1437

Merged
merged 11 commits into from
Oct 9, 2019
Merged

Conversation

alexbarnsley
Copy link
Member

Waiting on the crypto package to be updated to 2.6.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@alexbarnsley alexbarnsley added the Status: Needs Testcase The issue or pull request relates to a feature that needs test coverage. label Sep 4, 2019
@ghost
Copy link

ghost commented Sep 4, 2019

Your pull request doesn't have a test case, which is a requirement for it to be merged. Please provide it and one of the developers will review it before merging.

@ghost ghost added Complexity: Medium Less than 256 lines changed. Type: Feature The issue is a request for new functionality. labels Sep 4, 2019
@alexbarnsley alexbarnsley added the Status: In Progress The issue or pull request is being worked on. label Sep 4, 2019
@alexbarnsley alexbarnsley changed the title feat: v2 transactions with nonces [WIP] feat: v2 transactions with nonces Sep 4, 2019
@codecov-io
Copy link

codecov-io commented Sep 4, 2019

Codecov Report

Merging #1437 into feat/aip-11 will decrease coverage by 0.2%.
The diff coverage is 23.52%.

Impacted file tree graph

@@               Coverage Diff               @@
##           feat/aip-11    #1437      +/-   ##
===============================================
- Coverage         41.3%   41.09%   -0.21%     
===============================================
  Files              237      238       +1     
  Lines             6430     6453      +23     
  Branches          1273     1262      -11     
===============================================
- Hits              2656     2652       -4     
- Misses            3519     3541      +22     
- Partials           255      260       +5
Impacted Files Coverage Δ
...ransaction/TransactionForm/TransactionFormVote.vue 20% <ø> (ø) ⬆️
src/renderer/services/synchronizer.js 20.28% <ø> (ø) ⬆️
src/renderer/models/network.js 100% <ø> (ø) ⬆️
...TransactionForm/TransactionFormSecondSignature.vue 23.8% <ø> (ø) ⬆️
...actionForm/TransactionFormDelegateRegistration.vue 25% <ø> (ø) ⬆️
...action/TransactionForm/TransactionFormTransfer.vue 48.18% <ø> (ø) ⬆️
src/renderer/services/synchronizer/network.js 0% <0%> (ø)
src/renderer/App.vue 0% <0%> (ø) ⬆️
src/renderer/store/modules/network.js 38.77% <0%> (-5.42%) ⬇️
src/renderer/store/modules/peer.js 66.83% <23.07%> (-2.9%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 224a92c...3fa461f. Read the comment docs.

@alexbarnsley alexbarnsley changed the title [WIP] feat: v2 transactions with nonces [WIP] feat(aip-11): v2 transactions with nonces Sep 4, 2019
@alexbarnsley alexbarnsley changed the title [WIP] feat(aip-11): v2 transactions with nonces feat(aip-11): v2 transactions with nonces Oct 7, 2019
@alexbarnsley alexbarnsley removed the Status: In Progress The issue or pull request is being worked on. label Oct 7, 2019
@faustbrian faustbrian merged commit c30b854 into feat/aip-11 Oct 9, 2019
@faustbrian faustbrian deleted the feat/v2-tx-nonces branch October 9, 2019 09:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Complexity: Medium Less than 256 lines changed. Status: Needs Testcase The issue or pull request relates to a feature that needs test coverage. Type: Feature The issue is a request for new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants