This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 190
feat(aip-11): v2 transactions with nonces #1437
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbarnsley
added
the
Status: Needs Testcase
The issue or pull request relates to a feature that needs test coverage.
label
Sep 4, 2019
alexbarnsley
requested review from
faustbrian,
ItsANameToo and
luciorubeens
as code owners
September 4, 2019 12:39
Your pull request doesn't have a test case, which is a requirement for it to be merged. Please provide it and one of the developers will review it before merging. |
ghost
added
Complexity: Medium
Less than 256 lines changed.
Type: Feature
The issue is a request for new functionality.
labels
Sep 4, 2019
alexbarnsley
added
the
Status: In Progress
The issue or pull request is being worked on.
label
Sep 4, 2019
alexbarnsley
changed the title
feat: v2 transactions with nonces
[WIP] feat: v2 transactions with nonces
Sep 4, 2019
Codecov Report
@@ Coverage Diff @@
## feat/aip-11 #1437 +/- ##
===============================================
- Coverage 41.3% 41.09% -0.21%
===============================================
Files 237 238 +1
Lines 6430 6453 +23
Branches 1273 1262 -11
===============================================
- Hits 2656 2652 -4
- Misses 3519 3541 +22
- Partials 255 260 +5
Continue to review full report at Codecov.
|
alexbarnsley
changed the title
[WIP] feat: v2 transactions with nonces
[WIP] feat(aip-11): v2 transactions with nonces
Sep 4, 2019
ghost
mentioned this pull request
Sep 8, 2019
luciorubeens
reviewed
Oct 4, 2019
alexbarnsley
changed the title
[WIP] feat(aip-11): v2 transactions with nonces
feat(aip-11): v2 transactions with nonces
Oct 7, 2019
alexbarnsley
removed
the
Status: In Progress
The issue or pull request is being worked on.
label
Oct 7, 2019
luciorubeens
approved these changes
Oct 9, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Complexity: Medium
Less than 256 lines changed.
Status: Needs Testcase
The issue or pull request relates to a feature that needs test coverage.
Type: Feature
The issue is a request for new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on the crypto package to be updated to 2.6.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
develop
branch, not themaster
branchIf adding a new feature, the PR's description includes: