Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

fix: store server used to import as peer #1311

Merged
merged 5 commits into from
Sep 16, 2019
Merged

fix: store server used to import as peer #1311

merged 5 commits into from
Sep 16, 2019

Conversation

luciorubeens
Copy link
Contributor

Sets the server as a peer temporarily until it finds new peers.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@ghost ghost added Complexity: Low Less than 64 lines changed. Type: Bugfix The pull request fixes an incorrect functionality or behaviour. labels Jul 2, 2019
@codecov-io
Copy link

codecov-io commented Jul 2, 2019 •
edited
Loading

Codecov Report

Merging #1311 into develop will decrease coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1311      +/-   ##
===========================================
- Coverage    40.74%   40.68%   -0.06%     
===========================================
  Files          237      237              
  Lines         6561     6572      +11     
  Branches      1303     1296       -7     
===========================================
+ Hits          2673     2674       +1     
- Misses        3642     3653      +11     
+ Partials       246      245       -1
Impacted Files Coverage Δ
src/renderer/components/Network/NetworkModal.vue 40.93% <ø> (-0.73%) ⬇️
src/renderer/store/modules/peer.js 67.53% <0%> (-2.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc44a9...653b1ab. Read the comment docs.

@alexbarnsley
Copy link
Member

I think it might be worth doing SET_CURRENT_PEER here too. I noticed that when I first created a profile for a new network, I wasn't connected to a peer until I refreshed 🤔

@faustbrian
Copy link
Contributor

I think it might be worth doing SET_CURRENT_PEER here too. I noticed that when I first created a profile for a new network, I wasn't connected to a peer until I refreshed 🤔

@luciorubeens

@alexbarnsley alexbarnsley added the Status: Needs Changes The pull request needs additional changes before it can be merged. label Aug 21, 2019
@ghost
Copy link

ghost commented Aug 21, 2019

Your pull request needs some changes. Please wait for a comment from one of our developers for more information.

@ItsANameToo
Copy link
Member

@luciorubeens needs changes :crazypuppyeyes:

@luciorubeens
fix: store the server used to import the custom network as a peer
89530a4 
fix: development mode message in production (#1427)

* fix: development mode message in production

* fix: remove error log

* chore: add script to build win x64

feat: show if voted delegate is active in wallet table (#1410)

refactor: get wallet names in wallet selection/input address (#1394)

fix: port used from github peer list (#1430)

fix: properly format crypto currencies (#1402)

* fix: properly format crypto currencies

* chore: typo `precissely` -> `precisely`

* test: remove `only`

fix: close transaction show modal when clicking on addresses and navigate to transactions tab always (#1143)

* fix: close transaction show when clicking on and address and navigate to transactions tab always

* fix: close vote modal when clicking on and address and navigate to transactions tab always

* fix: hide the tooltip when clicking on a wallet address
@luciorubeens
fix: delay -> latency
49b9f5c
@luciorubeens
Copy link
Contributor Author

@alexbarnsley The peer was not being added to the list due to validation failure. Fixed by changing delay to latency.

@alexbarnsley
Copy link
Member

👌 thanks, will take a look after the release

@faustbrian
Copy link
Contributor

@alexbarnsley can this be reviewed and merged or does it need any changes?

@alexbarnsley
Copy link
Member

@luciorubeens you didn't do SET_CURRENT_PEER 🤔

@alexbarnsley
Copy link
Member

I mean, it loaded peers straight away so I'll merge

@alexbarnsley alexbarnsley changed the title fix: store the server used to import the custom network as a peer fix: store server used to import as peer Sep 16, 2019
@alexbarnsley alexbarnsley merged commit ca83eb9 into develop Sep 16, 2019
@ghost ghost deleted the fix/peer-bridge-chain branch September 16, 2019 09:26
@ghost ghost mentioned this pull request Sep 22, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexbarnsley alexbarnsley alexbarnsley approved these changes

@faustbrian faustbrian Awaiting requested review from faustbrian

@ItsANameToo ItsANameToo Awaiting requested review from ItsANameToo ItsANameToo is a code owner

Assignees
No one assigned
Labels
Complexity: Low Less than 64 lines changed. Status: Needs Changes The pull request needs additional changes before it can be merged. Type: Bugfix The pull request fixes an incorrect functionality or behaviour.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@luciorubeens @codecov-io @alexbarnsley @faustbrian @ItsANameToo