Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-p2p): fix peer connecting to itself #4143

Merged
merged 3 commits into from
Nov 3, 2020

Conversation

rainydio
Copy link
Contributor

@rainydio rainydio commented Nov 2, 2020

Summary

P2P getPeers endpoint now filters out ip of peer that made the call. Fixes #2890 4090

Checklist

  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #4143 into develop will decrease coverage by 0.51%.
The diff coverage is 66.55%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4143      +/-   ##
===========================================
- Coverage    96.66%   96.14%   -0.52%     
===========================================
  Files          716      721       +5     
  Lines        17227    17421     +194     
  Branches      2095     2118      +23     
===========================================
+ Hits         16653    16750      +97     
- Misses         416      506      +90     
- Partials       158      165       +7     
Flag Coverage Δ
functional 6.00% <11.26%> (+0.03%) ⬆️
integration 9.95% <0.34%> (-0.12%) ⬇️
unit 94.71% <55.29%> (-0.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-forger/src/client.ts 97.10% <ø> (ø)
packages/core-kernel/src/ioc/identifiers.ts 100.00% <ø> (ø)
packages/core-p2p/src/hapi-nes/client.ts 100.00% <ø> (ø)
packages/core/src/commands/env-get.ts 100.00% <ø> (ø)
...ackages/core-database/src/wallets-table-service.ts 13.33% <13.33%> (ø)
...ages/core-state/src/wallets/wallet-sync-service.ts 17.24% <17.24%> (ø)
packages/core-transaction-pool/src/service.ts 87.50% <18.18%> (-11.70%) ⬇️
...re-kernel/src/services/attributes/attribute-map.ts 84.00% <50.00%> (-4.00%) ⬇️
packages/core-transaction-pool/src/processor.ts 95.34% <66.66%> (-2.28%) ⬇️
packages/core-blockchain/src/blockchain.ts 91.70% <80.00%> (-0.29%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbbda7b...4ad4bd5. Read the comment docs.

@rainydio rainydio marked this pull request as ready for review November 2, 2020 05:48
@faustbrian faustbrian merged commit 4a825d1 into develop Nov 3, 2020
@faustbrian faustbrian deleted the fix/core-p2p/self-connection branch November 3, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants