Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core-manager): implement core-manager skeleton #3685

Merged
merged 11 commits into from
May 7, 2020

Conversation

sebastijankuzner
Copy link
Contributor

Summary

This PR includes new package core-manager which can be run as standalone process via manger:run as part of ARK cli. Current implementation doesn't include any planned features, but is prototype with JSON-RPC server run on top of HAPI server.

Actions for each JSON-RCP method are dinamicaly loaded from the actions folder and are going to be used in the future with appropriate business logic like:

  • snapshot management
  • system info
  • plugin instalation/removing
  • ...

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Code that is going to be removed in the future has not been tested (like: test action).

@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #3685 into develop will increase coverage by 0.01%.
The diff coverage is 94.52%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3685      +/-   ##
===========================================
+ Coverage    91.33%   91.35%   +0.01%     
===========================================
  Files          536      541       +5     
  Lines        12504    12577      +73     
  Branches      1553     1561       +8     
===========================================
+ Hits         11421    11490      +69     
- Misses        1082     1086       +4     
  Partials         1        1              
Impacted Files Coverage Δ
packages/core-manager/src/actions/test.ts 0.00% <0.00%> (ø)
packages/core-manager/src/action-reader.ts 100.00% <100.00%> (ø)
packages/core-manager/src/ioc/identifiers.ts 100.00% <100.00%> (ø)
packages/core-manager/src/server.ts 100.00% <100.00%> (ø)
packages/core-manager/src/service-provider.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5610706...c4b6234. Read the comment docs.

@faustbrian faustbrian merged commit fed54c9 into develop May 7, 2020
@ghost ghost deleted the feature/core-manager branch May 7, 2020 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants