fix(core-transaction-pool): use sorted array (instead of tree) for storing transactions by fee and nonce #3678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which is either the lowest fee 'last nonce tx' in the pool or a best guess based on a sample of 100 'last nonce txs'
ghost
added
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use sorted array instead of tree for storing transaction by fee and nonce, because tree has some issues like with recursion and max call stack. Sorted array is simpler and does the job for a lower max size of the transaction pool (now reduced to 15k transactions by default instead of 100k).
(tree memory structure is still available in core-utils and might be improved and used in the future : needs re-balancing while inserting to be usable)
Checklist