Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core-logger-pino): increase coverage to 100% #3580

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Mar 5, 2020

Resolves #3475

@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #3580 into develop will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3580      +/-   ##
===========================================
+ Coverage    60.63%   60.71%   +0.07%     
===========================================
  Files          547      547              
  Lines        13655    13653       -2     
  Branches      1866     1866              
===========================================
+ Hits          8280     8289       +9     
+ Misses        5347     5336      -11     
  Partials        28       28
Impacted Files Coverage Δ
packages/core-logger-pino/src/driver.ts 100% <ø> (+3.38%) ⬆️
...ckages/core-kernel/src/support/instance-manager.ts 85.71% <0%> (+9.52%) ⬆️
packages/core-logger-pino/src/service-provider.ts 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e428af2...2e4dbba. Read the comment docs.

@faustbrian faustbrian merged commit c1c7add into develop Mar 5, 2020
@faustbrian faustbrian deleted the pino-coverage branch March 5, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant