Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use application events from core-event-emitter #3574

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Mar 4, 2020

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #3574 into 2.6 will increase coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.6    #3574      +/-   ##
==========================================
+ Coverage   66.12%   66.12%   +<.01%     
==========================================
  Files         440      440              
  Lines       12477    12481       +4     
  Branches     1714     1714              
==========================================
+ Hits         8250     8253       +3     
- Misses       4193     4194       +1     
  Partials       34       34
Impacted Files Coverage Δ
packages/core/src/commands/snapshot/restore.ts 0% <0%> (ø) ⬆️
packages/core-transaction-pool/src/connection.ts 91.7% <100%> (ø) ⬆️
packages/core-state/src/stores/state.ts 91.46% <100%> (+0.1%) ⬆️
packages/core-p2p/src/peer-processor.ts 81.25% <100%> (ø) ⬆️
packages/core-container/src/container.ts 54.54% <50%> (+0.59%) ⬆️
packages/core-transactions/src/handlers/vote.ts 66.1% <50%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52bbf15...827055f. Read the comment docs.

@faustbrian faustbrian merged commit c2c93f0 into 2.6 Mar 4, 2020
@ghost ghost deleted the refactor/application-events branch March 4, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants