Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-transactions): undefined pool variable #3535

Merged
merged 5 commits into from
Feb 28, 2020

Conversation

rainydio
Copy link
Contributor

Summary

Undefined pool variable was suppressed by @ts-ignore and I missed it. Wallet repository can be referenced by this.walletRepository.

Checklist

  • Ready to be merged

@rainydio rainydio force-pushed the fix/core-transactions/undefined-pool branch from d68eebf to e4bd0a0 Compare February 25, 2020 15:35
@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #3535 into 3.0 will decrease coverage by 37.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0   #3535       +/-   ##
==========================================
- Coverage   47.52%   9.82%   -37.70%     
==========================================
  Files         548     548               
  Lines       13861   13861               
  Branches     1902    1902               
==========================================
- Hits         6587    1362     -5225     
- Misses       7245   12476     +5231     
+ Partials       29      23        -6     
Impacted Files Coverage Δ
packages/crypto/src/enums.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-p2p/src/schemas.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/crypto/src/constants.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-cli/src/contracts.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-p2p/src/constants.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/crypto/src/crypto/hash.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/crypto/src/crypto/slots.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/crypto/src/utils/base58.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/crypto/src/utils/bignum.ts 0.00% <0.00%> (-100.00%) ⬇️
packages/core-cli/src/application.ts 0.00% <0.00%> (-100.00%) ⬇️
... and 261 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c71cc33...23d747f. Read the comment docs.

@faustbrian faustbrian merged commit 9a8ecde into 3.0 Feb 28, 2020
@ghost ghost deleted the fix/core-transactions/undefined-pool branch February 28, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants