Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core-transaction-pool): collator test #3533

Closed
wants to merge 3 commits into from

Conversation

rainydio
Copy link
Contributor

@rainydio rainydio commented Feb 25, 2020

Summary

Part of #3482. It's missing catch coverage, because I need to implement logging first. It's difficult to mock otherwise. Also I noticed that it makes more sense to check for transaction size first before trying to validate it.

Checklist

  • Tests
  • Ready to be merged

@rainydio rainydio changed the title refactor(core-transaction-pool): collator test test(core-transaction-pool): collator test Feb 25, 2020
@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #3533 into 3.0 will decrease coverage by 0.61%.
The diff coverage is 21.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #3533      +/-   ##
==========================================
- Coverage   48.69%   48.07%   -0.62%     
==========================================
  Files         539      548       +9     
  Lines       13549    13861     +312     
  Branches     1823     1901      +78     
==========================================
+ Hits         6598     6664      +66     
- Misses       6922     7168     +246     
  Partials       29       29
Impacted Files Coverage Δ
packages/core-p2p/src/utils/build-rate-limiter.ts 66.66% <ø> (ø) ⬆️
...s/core-test-framework/src/app/generators/crypto.ts 91.17% <ø> (ø) ⬆️
packages/core-p2p/src/schemas.ts 100% <ø> (ø) ⬆️
...kages/crypto/src/transactions/types/transaction.ts 78.37% <ø> (ø) ⬆️
packages/crypto/src/validation/schemas.ts 100% <ø> (ø) ⬆️
packages/core-api/src/resources/delegate.ts 80% <ø> (ø) ⬆️
...ges/core-magistrate-api/src/routes/bridgechains.ts 0% <ø> (ø) ⬆️
packages/core-p2p/src/utils/socket.ts 11.53% <ø> (ø) ⬆️
packages/core/src/commands/snapshot-rollback.ts 50% <ø> (ø) ⬆️
...ypto/src/transactions/utils/bridgechain-schemas.ts 100% <ø> (ø) ⬆️
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95a546a...a17c491. Read the comment docs.

@rainydio
Copy link
Contributor Author

Already merged in #3499

@rainydio rainydio closed this Feb 28, 2020
@rainydio rainydio deleted the refactor/core-transaction-pool/collator-test branch May 4, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants