Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(magistrate): allow to resign business only when bridgechains are resigned #3524

Merged

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Feb 21, 2020

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #3524 into 2.6 will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##              2.6   #3524      +/-   ##
=========================================
- Coverage   66.12%   66.1%   -0.03%     
=========================================
  Files         439     440       +1     
  Lines       12468   12570     +102     
  Branches     1712    1733      +21     
=========================================
+ Hits         8245    8309      +64     
- Misses       4189    4227      +38     
  Partials       34      34
Impacted Files Coverage Δ
...-transactions/src/handlers/business-resignation.ts 57.89% <100%> (+3.6%) ⬆️
...ackages/core-magistrate-transactions/src/errors.ts 95.23% <100%> (+1.12%) ⬆️
...core-magistrate-transactions/src/handlers/utils.ts 100% <0%> (ø)
...nsactions/src/handlers/bridgechain-registration.ts 72.54% <0%> (+0.88%) ⬆️
...te-transactions/src/handlers/bridgechain-update.ts 45.23% <0%> (+1.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021ad47...d3494f9. Read the comment docs.

@faustbrian faustbrian merged commit fbb82f3 into 2.6 Feb 24, 2020
@ghost ghost deleted the refactor/magistrate/resign-business-after-bridgechains branch February 24, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants