Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: collapse duplicate logic #3273

Closed
wants to merge 1 commit into from

Conversation

ciband
Copy link
Contributor

@ciband ciband commented Nov 18, 2019

Summary

Reduced two if blocks to a single if block since their conditions
were exactly the same and they were sequencial statements.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Reduced two if blocks to a single if block since their conditions
were exactly the same and they were sequencial statements.
@ghost
Copy link

ghost commented Nov 18, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost added Complexity: Low labels Nov 18, 2019
@spkjp
Copy link
Contributor

spkjp commented Nov 19, 2019

This breaks the entire signature deserialization. We need to perform this check after each read, since otherwise, whenever there is no second signature, it will attempt to read non-existing or wrong bytes.

@spkjp spkjp closed this Nov 19, 2019
@ghost
Copy link

ghost commented Nov 19, 2019

Your pull request has been closed, thank you for trying to solve an issue. If you think it was closed prematurely please provide additional information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants