Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(crypto): adjust generic name schema #3229

Merged
merged 5 commits into from
Nov 11, 2019

Conversation

dated
Copy link
Contributor

@dated dated commented Nov 8, 2019

Summary

Closes #3223.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@ghost
Copy link

ghost commented Nov 8, 2019

Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@faustbrian faustbrian merged commit 58fb160 into ArkEcosystem:develop Nov 11, 2019
@ghost
Copy link

ghost commented Nov 11, 2019

Your pull request has been merged and marked as tier 4. It will earn you $20 USD.

@dated dated deleted the refactor/generic-name branch November 11, 2019 06:06
@spkjp
Copy link
Contributor

spkjp commented Nov 12, 2019

@dated
This breaks the following business registration: https://dexplorer.ark.io/api/transactions/b7cd7621f0dcbc030951e83e44f169a167c568acb91b32c2705499e246badf84?transform=false

The error I get:

data:"business-882686643483"
dataPath:".transactions[0].asset.businessRegistration.name"
keyword:"pattern"
message:"should match pattern "^[a-zA-Z0-9]+( [a-zA-Z0-9._-]+)*$""
params:Object {pattern: "^[a-zA-Z0-9]+( [a-zA-Z0-9._-]+)*$"}
parentSchema:Object {type: "string", pattern: "^[a-zA-Z0-9]+( [a-zA-Z0-9._-]+)*$"}
schema:"^[a-zA-Z0-9]+( [a-zA-Z0-9._-]+)*$"
schemaPath:"genericName/allOf/0/pattern"

However, the name should be valid.

@dated
Copy link
Contributor Author

dated commented Nov 12, 2019

You are right, my bad. A better regex would be ^[a-zA-Z0-9]+([ ._-][a-zA-Z0-9.]+)*$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants