Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-p2p): timeout promise race #3158

Merged
merged 6 commits into from
Oct 29, 2019
Merged

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Oct 29, 2019

Summary

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #3158 into develop will increase coverage by <.01%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #3158      +/-   ##
==========================================
+ Coverage    65.59%   65.6%   +<.01%     
==========================================
  Files          425     425              
  Lines        11930   11932       +2     
  Branches      1642    1642              
==========================================
+ Hits          7826    7828       +2     
  Misses        4067    4067              
  Partials        37      37
Impacted Files Coverage Δ
packages/core-p2p/src/socket-server/worker.ts 18.18% <ø> (+0.23%) ⬆️
packages/core-p2p/src/network-monitor.ts 73.35% <0%> (-0.29%) ⬇️
packages/core-p2p/src/utils/socket.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9330a8...461e146. Read the comment docs.

@faustbrian faustbrian merged commit 3443f3a into develop Oct 29, 2019
@ghost ghost deleted the fix/core-p2p/timeouts branch October 29, 2019 06:38
faustbrian pushed a commit that referenced this pull request Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants