Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-http-utils): use the request origin to avoid 404s #3071

Merged
merged 7 commits into from
Oct 16, 2019

Conversation

faustbrian
Copy link
Contributor

Summary

Resolves #3068.

This also ensures that wreck sends the request to the correct origin if the host or port have been modified.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #3071 into develop will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3071      +/-   ##
===========================================
+ Coverage    65.66%   65.75%   +0.08%     
===========================================
  Files          425      425              
  Lines        11744    11747       +3     
  Branches      1605     1606       +1     
===========================================
+ Hits          7712     7724      +12     
+ Misses        3996     3988       -8     
+ Partials        36       35       -1
Impacted Files Coverage Δ
...ages/core-http-utils/src/plugins/trailing-slash.ts 93.75% <100%> (+47.59%) ⬆️
packages/crypto/src/transactions/deserializer.ts 95.32% <0%> (+2.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dbe404...bd67894. Read the comment docs.

@faustbrian faustbrian merged commit 98c88c4 into develop Oct 16, 2019
@ghost ghost deleted the fix/trailing branch October 16, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants