Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reject V1 transactions after milestone #2879

Merged
merged 18 commits into from
Aug 21, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Aug 16, 2019

A summary of what changes this PR introduces and why they were made.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@spkjp spkjp force-pushed the refactor/crypto/v1-deprecation branch 2 times, most recently from 372d36c to d853e64 Compare August 17, 2019 16:21
@spkjp spkjp force-pushed the refactor/crypto/v1-deprecation branch from d853e64 to 5597869 Compare August 17, 2019 19:48
@codecov-io
Copy link

codecov-io commented Aug 17, 2019

Codecov Report

Merging #2879 into develop will decrease coverage by 0.21%.
The diff coverage is 67.41%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2879      +/-   ##
===========================================
- Coverage    67.91%   67.69%   -0.22%     
===========================================
  Files          405      405              
  Lines         9697     9724      +27     
  Branches       448      489      +41     
===========================================
- Hits          6586     6583       -3     
- Misses        3078     3103      +25     
- Partials        33       38       +5
Impacted Files Coverage Δ
...ages/core-jest-matchers/src/functional/accepted.ts 0% <ø> (ø) ⬆️
packages/crypto/src/managers/config.ts 97.61% <ø> (ø) ⬆️
packages/core-p2p/src/network-state.ts 7.69% <0%> (-0.31%) ⬇️
...ages/core-jest-matchers/src/functional/rejected.ts 0% <0%> (ø) ⬆️
packages/core-forger/src/manager.ts 55.23% <0%> (-1.08%) ⬇️
packages/core-blockchain/src/blockchain.ts 63.03% <0%> (-0.39%) ⬇️
...s/core-blockchain/src/processor/block-processor.ts 88.67% <0%> (ø) ⬆️
...ckages/core-transaction-pool/src/wallet-manager.ts 100% <100%> (ø) ⬆️
...s/core-api/src/handlers/transactions/controller.ts 80.48% <100%> (ø) ⬆️
packages/crypto/src/blocks/factory.ts 80.64% <100%> (+0.64%) ⬆️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3ed2f9...2373d3d. Read the comment docs.

@spkjp spkjp force-pushed the refactor/crypto/v1-deprecation branch from c0f1c02 to 6f65811 Compare August 18, 2019 23:35
Co-Authored-By: Brian Faust <[email protected]>
@spkjp spkjp force-pushed the refactor/crypto/v1-deprecation branch from 6f65811 to aa692fb Compare August 19, 2019 18:24
@faustbrian faustbrian merged commit 5df769b into develop Aug 21, 2019
@ghost ghost deleted the refactor/crypto/v1-deprecation branch August 21, 2019 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants