-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: reject V1 transactions after milestone #2879
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasild
reviewed
Aug 16, 2019
372d36c
to
d853e64
Compare
d853e64
to
5597869
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2879 +/- ##
===========================================
- Coverage 67.91% 67.69% -0.22%
===========================================
Files 405 405
Lines 9697 9724 +27
Branches 448 489 +41
===========================================
- Hits 6586 6583 -3
- Misses 3078 3103 +25
- Partials 33 38 +5
Continue to review full report at Codecov.
|
faustbrian
reviewed
Aug 18, 2019
c0f1c02
to
6f65811
Compare
Co-Authored-By: Brian Faust <[email protected]>
6f65811
to
aa692fb
Compare
faustbrian
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A summary of what changes this PR introduces and why they were made.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
develop
branch, not themaster
branchIf adding a new feature, the PR's description includes: