Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Configure rollup for crypto package build #2853

Merged
merged 4 commits into from
Aug 2, 2019
Merged

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Jul 30, 2019

Configure rollup for crypto package build.

It produces a lighter dist package which is useful when for example using the package in browsers.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov-io
Copy link

codecov-io commented Jul 30, 2019

Codecov Report

Merging #2853 into 2.6 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              2.6    #2853   +/-   ##
=======================================
  Coverage   66.79%   66.79%           
=======================================
  Files         377      377           
  Lines        8874     8874           
  Branches      430      465   +35     
=======================================
  Hits         5927     5927           
+ Misses       2914     2910    -4     
- Partials       33       37    +4
Impacted Files Coverage Δ
packages/core-api/src/handlers/utils.ts 76% <0%> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 41.66% <0%> (ø) ⬆️
...es/core-blockchain/src/replay/replay-blockchain.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51b9939...8456202. Read the comment docs.

@faustbrian
Copy link
Contributor

Resolves #2806

@air1one air1one marked this pull request as ready for review August 2, 2019 07:57
@air1one air1one requested review from kristjank and spkjp as code owners August 2, 2019 07:57
@faustbrian faustbrian merged commit 6515a93 into 2.6 Aug 2, 2019
@ghost ghost deleted the build/crypto-rollup branch August 2, 2019 08:18
@ghost ghost removed the Status: In Progress label Aug 2, 2019
vasild added a commit that referenced this pull request Aug 2, 2019
…o-db

* ArkEcosystem/core/2.6:
  build(crypto): configure rollup (#2853)
  feat: transaction type dependencies (#2859)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants