Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): start process in production env #2689

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Jun 12, 2019

Set NODE_ENV to production as many npm packages determine the current environment and optimize their code for production.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov-io
Copy link

Codecov Report

Merging #2689 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #2689   +/-   ##
=======================================
  Coverage     64.6%   64.6%           
=======================================
  Files          362     362           
  Lines         8178    8178           
  Branches       413     376   -37     
=======================================
  Hits          5283    5283           
- Misses        2857    2861    +4     
+ Partials        38      34    -4
Impacted Files Coverage Δ
packages/core/src/shared/start.ts 0% <ø> (ø) ⬆️
packages/core-api/src/handlers/utils.ts 77.27% <0%> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 41.66% <0%> (ø) ⬆️
...es/core-blockchain/src/replay/replay-blockchain.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8be1248...b000911. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #2689 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #2689   +/-   ##
=======================================
  Coverage     64.6%   64.6%           
=======================================
  Files          362     362           
  Lines         8178    8178           
  Branches       413     376   -37     
=======================================
  Hits          5283    5283           
- Misses        2857    2861    +4     
+ Partials        38      34    -4
Impacted Files Coverage Δ
packages/core/src/shared/start.ts 0% <ø> (ø) ⬆️
packages/core-api/src/handlers/utils.ts 77.27% <0%> (ø) ⬆️
packages/core-logger-winston/src/formatter.ts 41.66% <0%> (ø) ⬆️
...es/core-blockchain/src/replay/replay-blockchain.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8be1248...b000911. Read the comment docs.

@faustbrian faustbrian merged commit 39a423f into develop Jun 13, 2019
@ghost ghost deleted the faustbrian-patch-1 branch June 13, 2019 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants