Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core-event-emitter): extend the node.js event emitter #2440

Merged
merged 3 commits into from
Apr 18, 2019

Conversation

faustbrian
Copy link
Contributor

Proposed changes

Extend the node.js event emitter and overwrite certain methods to set the listener count.

Types of changes

  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@faustbrian faustbrian merged commit 9aeba81 into 2.4 Apr 18, 2019
@ghost ghost deleted the refactor/emitter branch April 18, 2019 05:07
@codecov-io
Copy link

Codecov Report

Merging #2440 into 2.4 will increase coverage by 0.04%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4    #2440      +/-   ##
==========================================
+ Coverage   68.16%   68.21%   +0.04%     
==========================================
  Files         387      387              
  Lines        8472     8472              
  Branches      434      394      -40     
==========================================
+ Hits         5775     5779       +4     
+ Misses       2648     2645       -3     
+ Partials       49       48       -1
Impacted Files Coverage Δ
packages/core-event-emitter/src/emitter.ts 92.3% <91.66%> (+30.76%) ⬆️
packages/core-logger-winston/src/formatter.ts 41.66% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83ac1e8...8b0de74. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants