refactor(corer-api): remove the legacy API #2439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The ci/circleci: test-node11-integration-0 job is failing as of 4d610f852c0830e6424316e0dae897f10e6e1afb. Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Codecov Report
@@ Coverage Diff @@
## 2.5 #2439 +/- ##
==========================================
- Coverage 68.16% 67.22% -0.95%
==========================================
Files 387 348 -39
Lines 8472 7774 -698
Branches 434 357 -77
==========================================
- Hits 5775 5226 -549
+ Misses 2648 2513 -135
+ Partials 49 35 -14
Continue to review full report at Codecov.
|
ghost
deleted the
ghost
mentioned this pull request
vasild
added a commit
that referenced
this pull request
May 22, 2019
…ve-incdec * ArkEcosystem/core/2.6: feat: initial nonce implementation (#2573) Merge develop into 2.5 (#2600) refactor(core-json-rpc): use blockId schema for validation (#2596) chore(core-database-postgres): add core-state dependency (#2598) fix(core-database-postgres): use day instead of date (#2595) refactor: use dayjs as it now has official UTC support (#2592) refactor(core-json-rpc): improved version of #2593 release: 2.3.23 (#2594) fix(core-json-rpc): allow use of old and new block IDs (#2593) fix(core-p2p): do not suspend peer for `AppNotReady` (#2590) chore(changelog): add latest changes for 2.4.0 (#2591) chore(ci): setup node.js 12 on CircleCI (#2474) fix(core-blockchain): divide blocks into smaller chunks for batch processing (#2586) refactor(crypto): fallback to ECDSA signature for version 2 transactions (#2584) fix(core-p2p): don't cause suspensions for unresponsive plugins (#2583) fix(core-p2p): don't cause suspensions for unresponsive plugins test(core-api): set p2p port on dummy peer feat(core): command to generate network configuration (#2582) fix(core-blockchain): delete bad rounds after unclean shutdown (#2581) feat(core-p2p): don't trust headers and verify config and plugin connectivity of peers (#2559) refactor: use ApplicationEvents enum instead of string (#2580) refactor(core-api): enforce "application/json" as content-type refactor(core-api): use pagination configuration limit test(e2e): remove version assertions chore(ci): update CircleCI configuration test(core-tester-cli): update API mock URLs refactor(core-api): register /api/v2 as a transition period fallback (#2578) test(core-api): use address identity refactor(corer-api): remove the legacy API (#2439)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Removes the legacy API from
ark-node.Will submit another PR that simplifies a few things, adds backwards compatibility with the
api/v2URIs and enforces a few things now that v1 deprecated.Types of changes
Checklist