Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crypto): implement TransactionFactory #2437

Merged
merged 1 commit into from
Apr 17, 2019
Merged

feat(crypto): implement TransactionFactory #2437

merged 1 commit into from
Apr 17, 2019

Conversation

faustbrian
Copy link
Contributor

Proposed changes

Same as #2429 but for transactions.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

@codecov-io
Copy link

Codecov Report

Merging #2437 into 2.4 will increase coverage by 0.03%.
The diff coverage is 86.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4    #2437      +/-   ##
==========================================
+ Coverage   68.03%   68.07%   +0.03%     
==========================================
  Files         385      386       +1     
  Lines        8448     8452       +4     
  Branches      393      393              
==========================================
+ Hits         5748     5754       +6     
+ Misses       2652     2650       -2     
  Partials       48       48
Impacted Files Coverage Δ
...kages/core-snapshots/src/transport/verification.ts 0% <0%> (ø) ⬆️
.../core-database-postgres/src/postgres-connection.ts 59.61% <0%> (ø) ⬆️
packages/core-database/src/database-service.ts 27.61% <0%> (ø) ⬆️
...ges/core-elasticsearch/src/indices/transactions.ts 0% <0%> (ø) ⬆️
packages/crypto/src/blocks/deserializer.ts 92.72% <100%> (ø) ⬆️
packages/core-transaction-pool/src/guard.ts 97.4% <100%> (ø) ⬆️
...kages/core-tester-cli/src/commands/debug/verify.ts 100% <100%> (ø) ⬆️
...ore-api/src/versions/1/transactions/transformer.ts 100% <100%> (ø) ⬆️
packages/core-transaction-pool/src/storage.ts 100% <100%> (ø) ⬆️
...ore-api/src/versions/2/transactions/transformer.ts 100% <100%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 201e6a7...adc0f74. Read the comment docs.

@faustbrian faustbrian merged commit f77ed69 into 2.4 Apr 17, 2019
@ghost ghost deleted the feat/tx-factory branch April 17, 2019 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants