refactor: block broadcast when block comes from forger #2430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
faustbrian
reviewed
Apr 16, 2019
| @@ -63,8 +63,9 @@ export async function postBlock({ req }): Promise<void> { | |||
| const blockchain: Blockchain.IBlockchain = app.resolvePlugin<Blockchain.IBlockchain>("blockchain"); | |||
|
|
|||
| const block: Interfaces.IBlockData = req.data.block; | |||
| const fromForger = isWhitelisted(app.resolveOptions("p2p").remoteAccess, req.headers.remoteAddress); | |||
There was a problem hiding this comment.
Suggested change
| const fromForger = isWhitelisted(app.resolveOptions("p2p").remoteAccess, req.headers.remoteAddress); | |
| const fromForger: boolean = isWhitelisted(app.resolveOptions("p2p").remoteAccess, req.headers.remoteAddress); |
faustbrian
reviewed
Apr 16, 2019
| @@ -310,9 +310,9 @@ export class NetworkMonitor implements P2P.INetworkMonitor { | |||
| // wait a bit before broadcasting if a bit early | |||
| const diff = blockPing.last - blockPing.first; | |||
| const maxHop = 4; | |||
| let proba = (maxHop - blockPing.count) / maxHop; | |||
| let broadcastQuota = (maxHop - blockPing.count) / maxHop; | |||
There was a problem hiding this comment.
Suggested change
| let broadcastQuota = (maxHop - blockPing.count) / maxHop; | |
| let broadcastQuota: number = (maxHop - blockPing.count) / maxHop; |
Codecov Report
@@ Coverage Diff @@
## 2.4 #2430 +/- ##
==========================================
+ Coverage 67.91% 67.92% +<.01%
==========================================
Files 385 385
Lines 8438 8443 +5
Branches 430 392 -38
==========================================
+ Hits 5731 5735 +4
- Misses 2659 2660 +1
Partials 48 48
Continue to review full report at Codecov.
|
faustbrian
approved these changes
Apr 16, 2019
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When block is received from forger, always broadcast to all peers.
Also refactored the block broadcast general logic, to use "peer quotas" based on block pings, instead of using randomization to select peers to broadcast to.
Types of changes
Checklist