Merge branch 'develop' into 2.3 #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2137) Do not attempt to download blocks from peers that are on a different chain because we know those blocks are not suitable for our chain.
* feat(core-p2p): Validate GET replies from other peers * chore(core-p2p): Remove call to a nonexistent function * fix(core-p2p): adjust tests to mock proper responses * chore(core-p2p): allow "common: null" in reply for common blocks * chore(core-p2p): Move replySchemas to a separate file
Previously we would fetch the list of peers from a single other peer and be satisfied with it as long as our list of peers satisfies hasMinimumPeers(). With this change we will query at least 4 peers and combine their lists. This will help in getting a better view of the network and all of its peers in times of splits and bad network connectivity.
* feat(core): ask for process restarts after updating * fix(core): no need for async/await * refactor(core): do not parse flags before they are needed * refactor(core): remove restart warning * fix(core): stop the spinner on error * refactor(core): restart processes after changing channels * fix(core): make sure the cli action is stopped on error * fix: stop action
|
@air1one @faustbrian - please review this in the next few days. Be sure to explicitly select labels so I know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
ghost
requested a review
from 
ghost
added
|
@supaiku0 Your pull request doesn't follow our contribution guidelines. Please review and correct it. |
Codecov Report
@@ Coverage Diff @@
## 2.3 #2157 +/- ##
==========================================
+ Coverage 76.31% 76.54% +0.22%
==========================================
Files 307 309 +2
Lines 8348 8373 +25
Branches 1160 1123 -37
==========================================
+ Hits 6371 6409 +38
+ Misses 1944 1930 -14
- Partials 33 34 +1
Continue to review full report at Codecov.
|
faustbrian
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
Checklist