Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): implement a CLI with @oclif to replace commander #2100

Merged
merged 84 commits into from
Feb 18, 2019

Conversation

faustbrian
Copy link
Contributor

Proposed changes

Resolves #1582
Resolves https://github.com/ArkEcosystem/core/milestone/5

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ghost
Copy link

ghost commented Feb 14, 2019

@air1one @supaiku0 - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost requested a review from air1one February 14, 2019 05:03
@ghost
Copy link

ghost commented Feb 14, 2019

@faustbrian The ci/circleci: test-node11-1 job is failing as of 8a0e83e3911006452b1a556e41eb9d63f617322c. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@codecov-io
Copy link

codecov-io commented Feb 14, 2019

Codecov Report

Merging #2100 into develop will increase coverage by 0.46%.
The diff coverage is 84.09%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2100      +/-   ##
===========================================
+ Coverage    78.92%   79.39%   +0.46%     
===========================================
  Files          330      329       -1     
  Lines         7973     7920      -53     
  Branches      1138     1132       -6     
===========================================
- Hits          6293     6288       -5     
+ Misses        1648     1599      -49     
- Partials        32       33       +1
Impacted Files Coverage Δ
...s/core-container/src/config/loaders/file-loader.ts 67.56% <ø> (ø) ⬆️
packages/core-p2p/src/monitor.ts 54.48% <100%> (+0.86%) ⬆️
packages/core-p2p/src/peer-verifier.ts 86.79% <100%> (-1.82%) ⬇️
packages/core-container/src/environment.ts 82.75% <57.14%> (ø) ⬆️
packages/core-p2p/src/peer.ts 88.34% <75%> (+0.11%) ⬆️
packages/core-container/src/registrars/plugin.ts 80.95% <75%> (+0.7%) ⬆️
packages/core-container/src/container.ts 51.72% <88.88%> (+2.94%) ⬆️
packages/core-p2p/src/errors.ts 90.9% <90.9%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c847f7...3ca3c1a. Read the comment docs.

spkjp
spkjp previously approved these changes Feb 18, 2019
@faustbrian faustbrian merged commit 3dc9a63 into develop Feb 18, 2019
@ghost ghost deleted the feat/core-cli branch February 18, 2019 13:23
@ghost ghost removed the Status: Needs Review label Feb 18, 2019
@vasild
Copy link
Contributor

vasild commented Feb 19, 2019

After this change it is no longer possible to override CORE_DB_USERNAME from the environment:

$ export CORE_DB_USERNAME=core
$ yarn --cwd packages/core relay:devnet
...
error: role "ark" does not exist

Is this intended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants