Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: 2.1.2 #2097

Merged
merged 4 commits into from
Feb 13, 2019
Merged

release: 2.1.2 #2097

merged 4 commits into from
Feb 13, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Feb 13, 2019

Proposed changes

  • Fix quorum related issues
  • Limit payload size
  • Remove signatures from transaction payload

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@spkjp spkjp requested a review from faustbrian February 13, 2019 14:07
@spkjp spkjp requested a review from kristjank as a code owner February 13, 2019 14:07
@ghost
Copy link

ghost commented Feb 13, 2019

@air1one @faustbrian - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost ghost requested a review from air1one February 13, 2019 14:07
@ghost ghost added the Status: Needs Review label Feb 13, 2019
@ghost
Copy link

ghost commented Feb 13, 2019

@supaiku0 Your pull request doesn't follow our contribution guidelines. Please review and correct it.

@ghost
Copy link

ghost commented Feb 13, 2019

@supaiku0 The ci/circleci: test-node10-2 job is failing as of e227cf712c917818141b6731c2b00d63ecae9069. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@ArkEcosystem ArkEcosystem deleted a comment Feb 13, 2019
@faustbrian faustbrian merged commit 64f2277 into ArkEcosystem:master Feb 13, 2019
@ghost ghost removed the Status: Needs Review label Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants