fix(core-json-rpc): retrieve bip38 wallet after creating it and return the encoded WIF

[zillionn]

Proposed changes

When there is no encryptedWif in the database:

core/packages/core-json-rpc/lib/server/utils/bip38-keys.js

Lines 8 to 10 in 6518001

	const encryptedWif = await database.get(
	utils.sha256(Buffer.from(userId)).toString('hex'),
	)

the catch is returning encryptedWif not encoded:

core/packages/core-json-rpc/lib/server/methods/wallets/bip38/create.js

Lines 20 to 36 in 6518001

	const { publicKey, privateKey } = crypto.getKeys(bip39.generateMnemonic())
	const encryptedWif = bip38.encrypt(
	Buffer.from(privateKey, 'hex'),
	true,
	params.bip38 + params.userId,
	)
	await database.set(
	utils.sha256(Buffer.from(params.userId)).toString('hex'),
	encryptedWif,
	)
	return {
	publicKey,
	address: crypto.getAddress(publicKey),
	wif: encryptedWif,
	}

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Refactoring (improve a current implementation without adding a new feature or fixing a bug)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Build (changes that affect the build system)
• Docs (documentation only changes)
• Test (adding missing tests or fixing existing tests)
• Other... Please describe:

Checklist

• I have read the CONTRIBUTING documentation
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

[zillionn]

Please test! Sometimes I get this error:

{
"error": {
"code": -32603,
"data": "TypeError: privateKey.copy is not a function\n at encodeRaw (/home/darknodeuser/ark-core/node_modules/wif/index.js:33:14)\n at Object.encode (/home/darknodeuser/ark-core/node_modules/wif/index.js:47:60)\n at method (/home/darknodeuser/ark-core/packages/core-json-rpc/lib/server/methods/wallets/bip38/create.js:33:27)",
"message": "privateKey.copy is not a function"
},
"id": "unique-request-id",
"jsonrpc": "2.0"
}

[zillionn]

I'm giving up.

[alexbarnsley]

No quitting :danstop:

[zillionn]

It's the stupid tests, I hate them! They just don't pass because this

core/packages/core-json-rpc/__tests__/wallets.test.js

Lines 157 to 160 in 6518001

	const response = await request('wallets.bip38.create', {
	bip38: 'this is a top secret passphrase',
	userId,
	})

returns this

data:
{ jsonrpc: '2.0',
id: '8612fcb3-e03a-4c38-8657-d41b9d8b6552',
error:
{ code: -32603,
message: 'privateKey.copy is not a function',
data:
'TypeError: privateKey.copy is not a function\n at encodeRaw (/Work/ark-core/node_modules/wif/index.js:33:14)\n at Object.encode (/Work/ark-core/node_modules/wif/index.js:47:60)\n at encode (/Work/ark-core/packages/core-json-rpc/lib/server/methods/wallets/bip38/create.js:34:29)' } } }

[faustbrian]

@zillionn adjusted it for you

[zillionn]

OK thanks, but will the tests pass???

[faustbrian]

Closing this as it required more changes after looking at the full picture.

#1653