refactor(core-magistrate-crypto): consolidate bridgechain schem… (#3143)

ArkEcosystem · Oct 27, 2019 · deef78d · deef78d
1 parent 2c619ae
commit deef78d
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 35 deletions.
diff --git a/packages/core-magistrate-crypto/src/transactions/bridgechain-registration.ts b/packages/core-magistrate-crypto/src/transactions/bridgechain-registration.ts
@@ -2,7 +2,7 @@ import { Transactions, Utils } from "@arkecosystem/crypto";
 import ByteBuffer from "bytebuffer";
 import { MagistrateTransactionGroup, MagistrateTransactionStaticFees, MagistrateTransactionType } from "../enums";
 import { IBridgechainRegistrationAsset } from "../interfaces";
-import { seedNodesSchema } from "./utils/bridgechain-schemas";
+import { bridgechainSchema } from "./utils/bridgechain-schema";
 
 const { schemas } = Transactions;
 
@@ -28,25 +28,7 @@ export class BridgechainRegistrationTransaction extends Transactions.Transaction
                             type: "object",
                             required: ["name", "seedNodes", "genesisHash", "bridgechainRepository"],
                             additionalProperties: false,
-                            properties: {
-                                name: {
-                                    type: "string",
-                                    minLength: 1,
-                                    maxLength: 40,
-                                },
-                                seedNodes: seedNodesSchema,
-                                genesisHash: {
-                                    type: "string",
-                                    minLength: 64,
-                                    maxLength: 64,
-                                    $ref: "transactionId",
-                                },
-                                bridgechainRepository: {
-                                    type: "string",
-                                    minLength: 1,
-                                    maxLength: 100,
-                                },
-                            },
+                            properties: bridgechainSchema,
                         },
                     },
                 },

diff --git a/packages/core-magistrate-crypto/src/transactions/bridgechain-update.ts b/packages/core-magistrate-crypto/src/transactions/bridgechain-update.ts
@@ -3,7 +3,7 @@ import ByteBuffer from "bytebuffer";
 import Long from "long";
 import { MagistrateTransactionGroup, MagistrateTransactionStaticFees, MagistrateTransactionType } from "../enums";
 import { IBridgechainUpdateAsset } from "../interfaces";
-import { seedNodesSchema } from "./utils/bridgechain-schemas";
+import { bridgechainSchema } from "./utils/bridgechain-schema";
 
 const { schemas } = Transactions;
 
@@ -27,10 +27,7 @@ export class BridgechainUpdateTransaction extends Transactions.Transaction {
                         bridgechainUpdate: {
                             type: "object",
                             required: ["bridgechainId", "seedNodes"],
-                            properties: {
-                                bridgechainId: { type: "integer", minimum: 1 },
-                                seedNodes: seedNodesSchema,
-                            },
+                            properties: bridgechainSchema,
                         },
                     },
                 },

diff --git a/packages/core-magistrate-crypto/src/transactions/utils/bridgechain-schema.ts b/packages/core-magistrate-crypto/src/transactions/utils/bridgechain-schema.ts
@@ -0,0 +1,32 @@
+export const bridgechainSchema = {
+    bridgechainId: {
+        type: "integer",
+        minimum: 1,
+    },
+    name: {
+        type: "string",
+        minLength: 1,
+        maxLength: 40,
+    },
+    seedNodes: {
+        type: "array",
+        minItems: 1,
+        maxItems: 10,
+        uniqueItems: true,
+        items: {
+            type: "string",
+            format: "peer",
+        },
+    },
+    genesisHash: {
+        type: "string",
+        minLength: 64,
+        maxLength: 64,
+        $ref: "transactionId",
+    },
+    bridgechainRepository: {
+        type: "string",
+        minLength: 1,
+        maxLength: 100,
+    },
+};
diff --git a/packages/core-magistrate-crypto/src/transactions/utils/bridgechain-schemas.ts b/packages/core-magistrate-crypto/src/transactions/utils/bridgechain-schemas.ts